Hi Greg:
Thanks for the patch! Indeed it fixes my problem -- no more Oops
during keyspan_pda_startup(), so I went on to try "cu -l /dev/ttyUSB0"
with the port wired with a loopback plug. The open succeeds, but
when I send a character, keyspan_pda_rx_interrupt() reports "bad magic
number for port". It looks like the urb->context it gets is a pointer
to usb_serial structure (magic number is USB_SERIAL_MAGIC == 0x6702)
rather than to a usb_serial_port structure (whose magic number should
be USB_SERIAL_PORT_MAGIC 0x7301).
On the theory that I've inadvertently introduced some new problem while
adding my debug code, I'm going to unpack vanilla sources and try again.
I see Brian just supplied a big new patch. I'll try that and keep
you posted. If I still see the bad magic number problem, I'll prepare
a report with system log details etc.
Thanks for your help.
--Peter
--
Peter E. Berger Tel: (218) 848-2885
Brimson Laboratories Fax: (218) 848-2433
1549 Hiironen Rd. Email: [EMAIL PROTECTED]
Brimson, MN 55602
> Hi Peter,
>
> Man, if only every bug report was this verbose. Thanks a lot!
>
> In looking at the stuff you just sent, and the code, I agree with you
> that this is a bug in the code. I don't have a Keyspan PDA device, and
> didn't write that chunk of code, but can think of a fix for it. Try the
> attached patch and let me know if it works for you.
>
> (there's a small memory leak in this patch if you when you remove the
> device, but it hopefully shouldn't oops anymore.)
>
> Ultimately, I think that Brian Warner needs to take a look at this too
> (he's the author of this portion of the driver.)
>
> That whole usb_serial_probe / startup section of code needs to be
> revisited soon. I know of a few different devices that wouldn't work
> with that function in its present state.
>
> Let me know if this works.
>
> greg k-h
...
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
