"Nemosoft Unv." wrote:

> Can you be more specific on what's wrong with find_format? Maybe I
> overlooked, but it seems the only place to insert the samplerate.

Why should it be taking into account the samplerate? Does
your device really have multiple entries with the same format
but different sampling rate ranges? if so then your device descriptor
looks cruelly wrong.

Also, some apps ask for sampling rates the device cannot do.
The device driver is expected to round this to the nearest supported
rate. Your patch badly breaks this (making the driver report failure).

Also, you may choose mono, even though the device can do stereo
and the app asked for stereo. Listening to MP3 in mono just isn't fun.

> No, it makes the Philips cams work :(

Yeah, just how common is the stupid philips cam compared to the
philips and Dallas DAC's?

Please send me the decriptors of your devices with lsusb,
the attached descriptor dumps are quite useless...

> Stop! You _have_ to take sampling rate into account. Matching only on the
> samplesize (8 vs. 16) bit and stereo/mono will not work; the routine as it
> was would simply take the first alternate interface that would match these 2
> parameters, and disregard samplerate altogether.

Yes, and that's intended and correct, unless some device has really
badly broken device descriptors.

Tom

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to