> > Comments?
>
> You should either make this root only or add more sanity checks.
It's already protected by your generic "must have O_RDWR" that
guards all usbdevfs ioctls, and I can't see a good reason to use
any different check.
> For example, size could get big (16k on IA32 if I remember right,
> but possibly much more on 64bit archs).
What's the issue there -- kmalloc won't go that big? 16k is the
limitation imposed by the ioctl framework itself, and it won't get
bigger than that unless ioctl codes use more than those 32 bits.
> And please use C-style comments
Easily changed, in the next version.
- Dave
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
