> Can you address Tom's comments?

My previous note did so, I think.


> And here are my comments:
> 
> a.  in proc_ioctl(), under "get input parameters", why no check
>     to see if kmalloc() fails?

Oops (so to speak ;-).  This was surely the "sketch" I promised!


> b.  in proc_ioctl(), under "ioctl to the driver which has claimed a
>     given interface", the code makes an assumption that interface
>     numbers are linear/consecutive (I think).  JE has found this not
>     to be the case (I believe on the cpia camera), although this
>     is out of spec IIRC.  That's why there is a usb_ifnum_to_if()
>     in usb.c.

Good to know.  I'll call that instead of making that assumption.

- Dave




---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to