On Tuesday 11 December 2007, eric miao wrote: > >From bcc027e2b6499823adb26ac6a70372395a9d5f19 Mon Sep 17 00:00:00 2001 > From: eric miao <[EMAIL PROTECTED]> > Date: Wed, 12 Dec 2007 08:53:25 +0800 > Subject: [PATCH] USB: update pxa27x ohci driver to use clk support > > Signed-off-by: eric miao <[EMAIL PROTECTED]>
Look basically OK except: > @@ -158,6 +161,10 @@ int usb_hcd_pxa27x_probe (const struct hc_driver > *driver, struct platform_device > return -ENOMEM; > } > > + usb_clk = clk_get(&pdev->dev, "USBCLK"); > + if (IS_ERR(usb_clk)) > + return PTR_ERR(usb_clk); > + > hcd = usb_create_hcd (driver, &pdev->dev, "pxa27x"); > if (!hcd) > return -ENOMEM; > @@ -201,6 +208,7 @@ int usb_hcd_pxa27x_probe (const struct hc_driver > *driver, struct platform_device > release_mem_region(hcd->rsrc_start, hcd->rsrc_len); > err1: > usb_put_hcd(hcd); > + clk_put(usb_clk); > return retval; > } > There's no clk_put in the remove() method. Does this need to go upstream for 2.6.24? - To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
