Hello Tony,
In drivers/usb/host/u132-hcd.c, in u132_probe() one can see that
there is a variable 'num_ports' which is assigned to, but then unused. git blame
says it comes from you:
commit 4b87361d49c04894458f4d4e80f9669abc894ae1
Author: Tony Olech <[EMAIL PROTECTED]>
Date: Wed Dec 6 13:16:22 2006 +0000
the important bits are here:
@@ -3121,10 +3079,24 @@ static void u132_initialise(struct u132 *u132, struct
platform_device *pdev)
static int __devinit u132_probe(struct platform_device *pdev)
{
struct usb_hcd *hcd;
+ int retval;
+ u32 control;
+ u32 rh_a = -1;
+ u32 num_ports;
msleep(100);
if (u132_exiting > 0) {
return -ENODEV;
- } /* refuse to confuse usbcore */
+ }
+ retval = ftdi_write_pcimem(pdev, intrdisable, OHCI_INTR_MIE);
+ if (retval)
+ return retval;
+ retval = ftdi_read_pcimem(pdev, control, &control);
+ if (retval)
+ return retval;
+ retval = ftdi_read_pcimem(pdev, roothub.a, &rh_a);
+ if (retval)
+ return retval;
+ num_ports = rh_a & RH_A_NDP; /* refuse to confuse usbcore */
if (pdev->dev.dma_mask) {
return -EINVAL;
}
So I'm wondering if it is safe to remove the unused code or maybe there is
something missing in
that commit?
Regards,
Mariusz
-
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
