Hi,
I'm slightly confused by this declaration in drivers/usb/storage/usb.c:
#define UNUSUAL_DEV(id_vendor, id_product, bcdDeviceMin, bcdDeviceMax, \
vendorName, productName,useProtocol, useTransport, \
initFunction, flags) \
...
and in unusual.h:
UAL_DEV( 0x03eb, 0x2002, 0x0100, 0x0100,
"ATMEL",
"SND1 Storage",
US_SC_DEVICE, US_PR_DEVICE, NULL,
US_FL_IGNORE_RESIDUE),
So US_SC_DEVICE ("Sub Classes" per include/linux/usb_usual.h) is used as a wild
card for useProtocol and US_PR_DEVICE ("Protocols") is the wildcard for
useTransport?
Shouldn't US_PR_DEVICE be used for useProtocol?
The two values are the same but it seems like asking for trouble to not
align the field/constant names correctly. Seems like someone cloning an
entry and replacing the wildcard will put the new value in the wrong place.
thanks,
grant
-
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
