On Sat, Jan 26, 2008 at 05:12:18PM +0100, Oliver Neukum wrote:
> Am Samstag, 26. Januar 2008 16:56:39 schrieb Alan Stern:
> > > "should" doesn't mean do. You want to make a change visible to user space.
> > > That needs a reason beyond coolness.
> >
> > There was a reason. ?Some device was using ID 0, and Greg wanted to
> > avoid a clash.
>
> Sorry. Yes, that's a good reason.
Yes, someone in the "wild" is using vendor id of 0x0000, so we need to
be "legal" :)
Here's the patch that I applied to my tree to fix this. Everything
seems fine to me, I should send a patch to usb.ids to add this info
too...
thanks,
greg k-h
--------------------
From: Greg Kroah-Hartman <[EMAIL PROTECTED]>
Subject: USB: use a real vendor and product id for root hubs
Turns out that a company is out there using the vendor id of 0x0000 in
the wild, so use a real vendor/product id for the root hubs.
Now that the Linux Foundation has a real vendor id, we use that, and the
first product id:
0x1d6b is the vendor id of the Linux Foundation
0x0001 is the product id for Linux root hubs
Signed-off-by: Greg Kroah-Hartman <[EMAIL PROTECTED]>
---
drivers/usb/core/hcd.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--- a/drivers/usb/core/hcd.c
+++ b/drivers/usb/core/hcd.c
@@ -132,8 +132,8 @@ static const u8 usb2_rh_dev_descriptor [
0x01, /* __u8 bDeviceProtocol; [ usb 2.0 single TT ]*/
0x40, /* __u8 bMaxPacketSize0; 64 Bytes */
- 0x00, 0x00, /* __le16 idVendor; */
- 0x00, 0x00, /* __le16 idProduct; */
+ 0x6b, 0x1d, /* __le16 idVendor; Linux Foundation */
+ 0x01, 0x00, /* __le16 idProduct; device 0x0001 */
KERNEL_VER, KERNEL_REL, /* __le16 bcdDevice */
0x03, /* __u8 iManufacturer; */
-
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
