Am Freitag, 1. Februar 2008 16:10:45 schrieb Alan Stern:
> On Fri, 1 Feb 2008, Oliver Neukum wrote:
>
> > Hi,
> >
> > this patch implements autosuspend for USB audio devices.
>
> > @@ -1937,6 +1945,7 @@ static int snd_usb_pcm_close(struct snd_pcm_substream
> > *substream, int direction)
> > subs->interface = -1;
> > }
> > subs->pcm_substream = NULL;
> > + usb_autopm_put_interface(subs->stream->chip->pm_intf);
> > return 0;
> > }
>
> You need to be very careful here. It's illegal to call
> usb_autopm_put_interface() after the disconnect method has returned.
OK, I'll look at that.
> Also I didn't notice any support for reset_resume in your patch. Not
> adding it is a bad policy -- particularly since we know of a USB audio
> device that needs the RESET_RESUME quirk.
You want it all at once ;-)
Regards
Oliver
-
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
