On Mon, Sep 10, 2012 at 07:05:15PM +0200, Sebastian Andrzej Siewior wrote:
> On 09/10/2012 06:40 PM, Fengguang Wu wrote:
> >tree: git://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git master
> >head: d9c88901337158c9f253a7de58a10b5125d61d26
> >commit: 7a7322b0a5d984025dd4faea9098b8fef07f8d8f [33/36] usb: gadget: remove
> >usb_gadget_controller_number()
> >
> >All sparse warnings:
>
> Once again, thank you.
You are welcome!
> > drivers/usb/gadget/f_acm.c:287:9: sparse: advancing past deep designator
> > drivers/usb/gadget/f_obex.c:60:9: sparse: advancing past deep designator
> > drivers/usb/gadget/f_serial.c:134:9: sparse: advancing past deep
> > designator
> > drivers/usb/gadget/serial.c:66:9: sparse: advancing past deep designator
>
> I don't get these. The purpose is an all NULL terminating entry. Could
> this be a sparse bug or is the [] / {} switch not really good C code?
http://marc.info/?l=linux-sparse&m=130673652023059&w=4
According to Dan's explanations, I'll filter out these warnings in future.
> >+ drivers/usb/gadget/serial.c:89:22: sparse: cast truncates bits from
> >constant value (24000000 becomes 0)
>
> I've sent a patch for this.
Thank you!
Fengguang
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html