This patch (as1606) converts two warning messages in the ehci-hcd
driver to debug messages, and adds a little extra information to each.

The log messages occur when an EHCI controller takes too long (more
than 20 ms) to turn its async or periodic schedule on or off.  If this
happens at all, it's liable to happen quite often and there's no point
spamming the system log with these warnings.  Furthermore, there's
nothing much we can do about it when the problem happens.

Signed-off-by: Alan Stern <[email protected]>
Reported-and-tested-by: Thomas Voegtle <[email protected]>

---

Greg, this patch should get into 3.6-final if possible.  It does not
need to be applied to any stable trees because the warning messages in
question were not added until 3.6-rc1.



 drivers/usb/host/ehci-timer.c |    6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

Index: usb-3.6/drivers/usb/host/ehci-timer.c
===================================================================
--- usb-3.6.orig/drivers/usb/host/ehci-timer.c
+++ usb-3.6/drivers/usb/host/ehci-timer.c
@@ -118,7 +118,8 @@ static void ehci_poll_ASS(struct ehci_hc
                        ehci_enable_event(ehci, EHCI_HRTIMER_POLL_ASS, true);
                        return;
                }
-               ehci_warn(ehci, "Waited too long for the async schedule status, 
giving up\n");
+               ehci_dbg(ehci, "Waited too long for the async schedule status 
(%x/%x), giving up\n",
+                               want, actual);
        }
        ehci->ASS_poll_count = 0;
 
@@ -163,7 +164,8 @@ static void ehci_poll_PSS(struct ehci_hc
                        ehci_enable_event(ehci, EHCI_HRTIMER_POLL_PSS, true);
                        return;
                }
-               ehci_warn(ehci, "Waited too long for the periodic schedule 
status, giving up\n");
+               ehci_dbg(ehci, "Waited too long for the periodic schedule 
status (%x/%x), giving up\n",
+                               want, actual);
        }
        ehci->PSS_poll_count = 0;
 

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to