On Wed, Oct 10, 2012 at 4:39 PM, Oliver Neukum <[email protected]> wrote: > On Wednesday 10 October 2012 16:17:25 Ming Lei wrote: >> On Wed, Oct 10, 2012 at 1:51 PM, Oliver Neukum <[email protected]> wrote: > >> > We need to use GFP_NOIO in situations the helper cannot know about. >> > Please add a gfp_t parameter. Then the caller will solve that. >> >> Considered that most of drivers call the helpers in different context, I >> think >> it is better to switch the gpf_t flag runtime inside helpers, like below: >> >> if (dev->power.runtime_status == RPM_RESUMING) >> gfp = GFP_NOIO; >> else >> gfp = GFP_KERNEL; > > You are admirably persistent ;-)
I am only trying to solve the problem more generally, :-) > If you extended the check to RPM_SUSPENDING it might work, > but still the problem with error handling exists. Could you describe the error handling case in a bit detail so that callers of these helpers can know when GFP_KERNEL is to be passed and when GFP_NOIO is taken if the gfp patamerer has to be added? Thanks, -- Ming Lei -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
