On Tue, 30 Oct 2012, Bhavik Kothari wrote:
> Hi Alan,
>
> Please find attached patch file. We have made a patch file in Linux 3.6.1
> version.
>
> Let us know your inputs.
> --- a/linux-3.6.1/drivers/usb/core/hub.c 2012-10-07 21:11:28.000000000
> +0530
> +++ b/linux-3.6.1/drivers/usb/core/hub.c 2012-10-30 11:23:17.121599414
> +0530
> @@ -1078,6 +1078,14 @@ static void hub_activate(struct usb_hub
> clear_port_feature(hub->hdev, port1,
> USB_PORT_FEAT_C_BH_PORT_RESET);
> }
> + /* Clear Port Reset bit (PORT_RC) */
This comment isn't needed. It's pretty easy to see what bit the
clear_port_feature() call below affects.
> + if ((portchange & USB_PORT_STAT_C_RESET) &&
> + hub_is_superspeed(hub->hdev)) {
You don't need to test for SuperSpeed. Clearing the C_RESET bit is
okay even with non-SuperSpeed hubs.
> + need_debounce_delay = true;
> + clear_port_feature(hub->hdev, port1,
> + USB_PORT_FEAT_C_RESET);
> + }
> +
Otherwise it looks okay.
Alan Stern
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
