Hi, On Wed, Nov 07, 2012 at 06:55:03PM +0530, Vivek Gautam wrote: > Hi, > > > On Tue, Nov 6, 2012 at 10:13 PM, Felipe Balbi <[email protected]> wrote: > > On Tue, Nov 06, 2012 at 08:58:49PM +0530, Vivek Gautam wrote: > >> Adding DWC3 device tree node for Exynos5250 along with the > >> device address and clock support needed for the controller. > >> > >> Signed-off-by: Vivek Gautam <[email protected]> > >> --- > >> arch/arm/boot/dts/exynos5250.dtsi | 6 ++++++ > >> arch/arm/mach-exynos/clock-exynos5.c | 24 ++++++++++++++++++++++++ > >> arch/arm/mach-exynos/include/mach/map.h | 1 + > >> arch/arm/mach-exynos/mach-exynos5-dt.c | 2 ++ > >> drivers/usb/Kconfig | 1 + > >> 5 files changed, 34 insertions(+), 0 deletions(-) > >> > >> diff --git a/arch/arm/boot/dts/exynos5250.dtsi > >> b/arch/arm/boot/dts/exynos5250.dtsi > >> index cf6a02d..52bca54 100644 > >> --- a/arch/arm/boot/dts/exynos5250.dtsi > >> +++ b/arch/arm/boot/dts/exynos5250.dtsi > >> @@ -68,6 +68,12 @@ > >> interrupts = <0 96 0>; > >> }; > >> > >> + dwc3 { > > > > shouldn't this be usb@12000000 ?? > > > Kept this in accordance with controller's name, similar to the change > in following: > http://www.mail-archive.com/[email protected]/msg12800.html > > Needs to be changed ?
I'll leave it to DT experts, but I was under the impression that we should be using generic functionality names (usb, i2c, spi, uart, gpio, etc) instead of the IP name. IP name is something more for compatible flag. Don't take my word for it though :-) DT experts are the ones with final saying -- balbi
signature.asc
Description: Digital signature
