Am 17.11.2012 16:06, schrieb Dan Carpenter: > If param->length is zero, then this could lead to a divide by zero bug > later in the function when we do: size %= max; > > Signed-off-by: Dan Carpenter <[email protected]> > > diff --git a/drivers/usb/misc/usbtest.c b/drivers/usb/misc/usbtest.c > index f10bd97..7667b12 100644 > --- a/drivers/usb/misc/usbtest.c > +++ b/drivers/usb/misc/usbtest.c > @@ -423,6 +423,9 @@ alloc_sglist(int nents, int max, int vary) > unsigned i; > unsigned size = max; > > + if (max == 0) > + return NULL; > +
maybe you should be more defensive and check from (max <= 0) re, wh > sg = kmalloc_array(nents, sizeof *sg, GFP_KERNEL); > if (!sg) > return NULL; > -- > To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in > the body of a message to [email protected] > More majordomo info at http://vger.kernel.org/majordomo-info.html > > -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
