On 10/04/2018 15:16, nisar.sa...@microchip.com wrote:
> Thanks Phil, for identifying the issues.
>> - ret = lan78xx_reset(dev);
>> - if (ret < 0)
>> - goto done;
>> netif_dbg(dev, ifup, dev->net, "phy initialised successfully");
> You may need to start the interrupts before "phy_start" instead of
> suppressing call to "lan78xx_reset".
> + if (dev->domain_data.phyirq > 0)
> + phy_start_interrupts(dev->net->phydev);
Shouldn't phy_connect_direct, called from lan78xx_phy_init, already have
enabled interrupts for us?
This patch addresses two problems - time wasted by renegotiating the link after
the reset and the
missed interrupt - and I'd like both to be fixed. Unless you can come up with a
good reason for
performing the reset from the open handler I think it should be removed.
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html