Hi,
> From: Johan Hovold, Sent: Wednesday, April 18, 2018 5:42 PM
>
> On Wed, Apr 18, 2018 at 04:22:31AM +0000, Yoshihiro Shimoda wrote:
> > Hi,
> >
> > > From: Johan Hovold, Sent: Saturday, April 14, 2018 10:06 PM
> > >
> > > Drop support for legacy phys which hasn't been used with a mainline
> > > kernel since commit 9080b8dc761a ("ARM: OMAP2+: Remove legacy usb-host.c
> > > platform init code"). Specifically, since that commit usb_get_phy_dev()
> > > have always returned -ENODEV and consequently this code has not been
> > > used.
> > >
> > > Signed-off-by: Johan Hovold <[email protected]>
> > > ---
> > > drivers/usb/renesas_usbhs/common.h | 1 -
> > > drivers/usb/renesas_usbhs/rcar2.c | 29 -----------------------------
> > > 2 files changed, 30 deletions(-)
> >
> > Thank you for the patch!
> > The drivers/usb/renesas_usbhs/mod_gadget.c still uses the legacy phy
> > API (usb_get_phy()).
> > Also this patch set doesn't drop the API. So, I think this subject
> > should be changed.
> > What do you think?
>
> Good point, I'll try to rephrase it.
>
> How about
>
> USB: renesas_usbhs: drop unused legacy-phy support
>
> and then I amend the commit message with a note about the legacy API
> still being used in gadget mode to bind the peripheral controller?
It sounds good to me.
When you submit v2 patch, would you add my Acked-by?
Acked-by: Yoshihiro Shimoda <[email protected]>
Best regards,
Yoshihiro Shimoda
> > Dropping usb_get_phy_dev() from this driver is good to me.
>
> Thanks,
> Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
