Hi
> -----Original Message-----
> From: Mats Karrman [mailto:[email protected]]
> Sent: 2018年5月12日 3:49
> To: Jun Li <[email protected]>; [email protected]; [email protected];
> [email protected]; [email protected]
> Cc: [email protected]; [email protected];
> [email protected]; Peter Chen <[email protected]>;
> [email protected]; [email protected]; [email protected];
> dl-linux-imx <[email protected]>
> Subject: Re: [PATCH v5 01/14] dt-bindings: connector: add properties for typec
>
> Hi Li Jun,
>
> On 2018-05-03 02:24, Li Jun wrote:
>
> > Add bingdings supported by current typec driver, so user can pass all
> > those properties via dt.
> >
> > Signed-off-by: Li Jun <[email protected]>
> > ---
> > .../bindings/connector/usb-connector.txt | 44
> +++++++++++++++
> > include/dt-bindings/usb/pd.h | 62
> ++++++++++++++++++++++
> > 2 files changed, 106 insertions(+)
> >
> > diff --git
> > a/Documentation/devicetree/bindings/connector/usb-connector.txt
> > b/Documentation/devicetree/bindings/connector/usb-connector.txt
> > index e1463f1..4b19de6d0 100644
> > --- a/Documentation/devicetree/bindings/connector/usb-connector.txt
> > +++ b/Documentation/devicetree/bindings/connector/usb-connector.txt
> > @@ -15,6 +15,33 @@ Optional properties:
> > - type: size of the connector, should be specified in case of USB-A, USB-B
> > non-fullsize connectors: "mini", "micro".
> >
> > +Optional properties for usb-c-connector:
> > +- power-role: should be one of "source", "sink" or "dual"(DRP) if
> > +typec
> > + connector has power support.
> > +- try-power-role: preferred power role if "dual"(DRP) can support
> > +Try.SNK
> > + or Try.SRC, should be "sink" for Try.SNK or "source" for Try.SRC.
> > +- data-role: should be one of "host", "device", "dual"(DRD) if typec
> > + connector supports USB data.
> > +
> > +Required properties for usb-c-connector with power delivery support:
> > +- source-pdos: An array of u32 with each entry providing supported
> > +power
> > + source data object(PDO), the detailed bit definitions of PDO can be
> > +found
> > + in "Universal Serial Bus Power Delivery Specification" chapter
> > +6.4.1.2
> > + Source_Capabilities Message, the order of each entry(PDO) should
> > +follow
> > + the PD spec chapter 6.4.1. Required for power source and power dual
> role.
> > + User can specify the source PDO array via PDO_FIXED/BATT/VAR()
> > +defined in
> > + dt-bindings/usb/pd.h.
> > +- sink-pdos: An array of u32 with each entry providing supported
> > +power
> > + sink data object(PDO), the detailed bit definitions of PDO can be
> > +found
> > + in "Universal Serial Bus Power Delivery Specification" chapter
> > +6.4.1.3
> > + Sink Capabilities Message, the order of each entry(PDO) should
> > +follow
> > + the PD spec chapter 6.4.1. Required for power sink and power dual role.
> > + User can specify the sink PDO array via PDO_FIXED/BATT/VAR()
> > +defined in
> > + dt-bindings/usb/pd.h.
> > +- op-sink-microwatt: Sink required operating power in microwatt, if
> > +source
> > + can't offer the power, Capability Mismatch is set, required for
> > +power
>
> ...set. Required...
> (new sentence, otherwise it's unclear what is required; op-sink-microwatt or
> Capability Mismatch set)
OK, will update as you suggested.
Thanks
Li Jun
N�����r��y����b�X��ǧv�^�){.n�+����{������^n�r���z���h�����&�� �G���h�(�階�ݢj"���m������z�ޖ���f���h���~�m�
