On Thu, May 17, 2018 at 09:44:40AM -0700, Randy Dunlap wrote:
> On 05/17/2018 09:20 AM, Greg KH wrote:
> >> +  file_data = kzalloc(sizeof(*file_data), GFP_KERNEL);
> >> +  if (!file_data)
> >> +          return -ENOMEM;
> >> +
> >> +  pr_debug("%s - called\n", __func__);
> > Please do not add "tracing" functions like this.  The kernel has a
> > wonderful built-in function tracing functionality, don't try to write
> > your own.  These lines should just be removed.
> 
> 
> but pr_debug() works great with DYNAMIC_DEBUG.

Sure, but don't do that for "I made it to this function!" type calls.
We have been ripping them out for a long time now, don't add new ones
please.

> Someone does not need to go all the way to tracing to get decent
> debug capability.

ftrace is not hard to use, it's even easier than dynamic_debug at times
:)

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to