Some of the .allow_link() and .drop_link() operations implementations
call config_group_find_item() and then leak the reference to the
returned item. Fix this by dropping those references where needed.

Signed-off-by: Laurent Pinchart <[email protected]>
---
 drivers/usb/gadget/function/uvc_configfs.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/usb/gadget/function/uvc_configfs.c 
b/drivers/usb/gadget/function/uvc_configfs.c
index dbc95c9558de..8d513cc6fb8c 100644
--- a/drivers/usb/gadget/function/uvc_configfs.c
+++ b/drivers/usb/gadget/function/uvc_configfs.c
@@ -529,6 +529,7 @@ static int uvcg_control_class_allow_link(struct config_item 
*src,
 unlock:
        mutex_unlock(&opts->lock);
 out:
+       config_item_put(header);
        mutex_unlock(su_mutex);
        return ret;
 }
@@ -564,6 +565,7 @@ static void uvcg_control_class_drop_link(struct config_item 
*src,
 unlock:
        mutex_unlock(&opts->lock);
 out:
+       config_item_put(header);
        mutex_unlock(su_mutex);
 }
 
@@ -2026,6 +2028,7 @@ static int uvcg_streaming_class_allow_link(struct 
config_item *src,
 unlock:
        mutex_unlock(&opts->lock);
 out:
+       config_item_put(header);
        mutex_unlock(su_mutex);
        return ret;
 }
@@ -2066,6 +2069,7 @@ static void uvcg_streaming_class_drop_link(struct 
config_item *src,
 unlock:
        mutex_unlock(&opts->lock);
 out:
+       config_item_put(header);
        mutex_unlock(su_mutex);
 }
 
-- 
Regards,

Laurent Pinchart

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to