Re: [PATCH] usb: gadget: atmel: remove pointless retrieval of DT name property

[Nicolas Ferre]

On 29/08/2018 at 22:01, Rob Herring wrote:

The name is always non-NULL and then is not used anywhere in this function,
so remove it.

Indeed.

Cc: Nicolas Ferre <nicolas.fe...@microchip.com>

Acked-by: Nicolas Ferre <nicolas.fe...@microchip.com>

Cc: Felipe Balbi <ba...@kernel.org>
Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org>
Cc: Alexandre Belloni <alexandre.bell...@bootlin.com>
Cc: linux-arm-ker...@lists.infradead.org
Cc: linux-usb@vger.kernel.org
Signed-off-by: Rob Herring <r...@kernel.org>
---
  drivers/usb/gadget/udc/atmel_usba_udc.c | 6 ------
  1 file changed, 6 deletions(-)

diff --git a/drivers/usb/gadget/udc/atmel_usba_udc.c 
b/drivers/usb/gadget/udc/atmel_usba_udc.c
index 17147b8c771e..5729935c5eb2 100644
--- a/drivers/usb/gadget/udc/atmel_usba_udc.c
+++ b/drivers/usb/gadget/udc/atmel_usba_udc.c
@@ -2004,7 +2004,6 @@ static struct usba_ep * atmel_udc_of_init(struct 
platform_device *pdev,
                                                    struct usba_udc *udc)
  {
        u32 val;
-       const char *name;
        struct device_node *np = pdev->dev.of_node;
        const struct of_device_id *match;
        struct device_node *pp;
@@ -2094,11 +2093,6 @@ static struct usba_ep * atmel_udc_of_init(struct 
platform_device *pdev,
                ep->can_dma = of_property_read_bool(pp, "atmel,can-dma");
                ep->can_isoc = of_property_read_bool(pp, "atmel,can-isoc");

- ret = of_property_read_string(pp, "name", &name);

-               if (ret) {
-                       dev_err(&pdev->dev, "of_probe: name error(%d)\n", ret);
-                       goto err;
-               }
                sprintf(ep->name, "ep%d", ep->index);
                ep->ep.name = ep->name;

--
Nicolas Ferre