On Wed, Sep 05, 2018 at 03:01:26PM +0530, Manu Gautam wrote: > Hi, > > > On 9/5/2018 3:04 AM, Prakruthi Deepak Heragu wrote: > > Add support for control peripheral of EUD (Embedded USB Debugger) to > > listen to events such as USB attach/detach, charger enable/disable, pet > > EUD to indicate software is functional. > > > > Signed-off-by: Satya Durga Srinivasu Prabhala <[email protected]> > > Signed-off-by: Prakruthi Deepak Heragu <[email protected]> > > --- > > drivers/soc/qcom/Kconfig | 12 ++ > > drivers/soc/qcom/Makefile | 1 + > > drivers/soc/qcom/eud.c | 338 > > ++++++++++++++++++++++++++++++++++++++++++++++ > > 3 files changed, 351 insertions(+) > > create mode 100644 drivers/soc/qcom/eud.c > > > > diff --git a/drivers/soc/qcom/Kconfig b/drivers/soc/qcom/Kconfig > [snip] > > + > > +#define EUD_ENABLE_CMD 1 > > +#define EUD_DISABLE_CMD 0 > > Why not use module param as boolean? I mean zero to disable and non-zero to > enable?
Never use module parameters on new code, as it's really hard to ever change them. It also doesn't work for multiple devices of the same type. thanks, greg k-h
