HI Felipe, >-----Original Message----- >From: Felipe Balbi [mailto:[email protected]] >Sent: Wednesday, December 05, 2018 2:32 PM >To: Anurag Kumar Vulisha <[email protected]>; Greg Kroah-Hartman ><[email protected]>; Shuah Khan <[email protected]>; Alan Stern ><[email protected]>; Johan Hovold <[email protected]>; Jaejoong Kim ><[email protected]>; Benjamin Herrenschmidt <[email protected]>; >Roger Quadros <[email protected]>; Manu Gautam <[email protected]>; >[email protected]; Bart Van Assche <[email protected]>; Mike >Christie <[email protected]>; Matthew Wilcox <[email protected]>; Colin Ian >King <[email protected]> >Cc: [email protected]; [email protected]; >[email protected]; Thinh Nguyen <[email protected]>; Tejas Joglekar ><[email protected]>; Ajay Yugalkishore Pandey <[email protected]>; >Anurag Kumar Vulisha <[email protected]> >Subject: Re: [PATCH v7 05/10] usb: dwc3: make controller clear transfer >resources >after complete > > >Hi, > >Anurag Kumar Vulisha <[email protected]> writes: >> @@ -2487,6 +2497,11 @@ static void dwc3_endpoint_interrupt(struct dwc3 *dwc, >> } >> >> switch (event->endpoint_event) { >> + case DWC3_DEPEVT_XFERCOMPLETE: >> + if (!dep->stream_capable) >> + break; >> + dep->flags &= ~DWC3_EP_TRANSFER_STARTED; >> + /* Fall Through */ > >instead, let's add a proper handler for this: > >dwc3_gadget_endpoint_transfer_complete(dep, event); > >That handler should be "self-sufficient". IOW, we shouldn't have this >fall through here. This means that the other patch where you modify >dwc3_gadget_transfer_in_progress() shouldn't be necessary, since that >event shouldn't run for stream capable endpoints. >
Thanks for your suggestion, will implement the changes as said and send the patches >While rewriting the patches, please rebase on my testing/next as I have >applied a few of the patches in this series. Okay , will rebase on top of testing/next and send the patches Best Regards, Anurag Kumar Vulisha
