Hi,
On Wed, Dec 12, 2012 at 10:13:27PM +0100, Linus Walleij wrote:
> On Tue, Nov 27, 2012 at 3:11 PM, Linus Walleij <linus.wall...@linaro.org>
> wrote:
> > On Wed, Nov 21, 2012 at 3:33 PM, Linus Walleij <linus.wall...@linaro.org>
> > wrote:
> >> On Wed, Nov 14, 2012 at 3:40 PM, Linus Walleij
> >> <linus.wall...@stericsson.com> wrote:
> >>
> >>> From: Haipeng YU <haipeng...@stericsson.com>
> >>>
> >>> When a device is switched off by software, gserial_cleanup will
> >>> be called, and switch off will be blocked in this function
> >>> because wake_up_interruptible() in gs_close() can not wake_up
> >>> the wait_event() in gserial_cleanup(), it should be changed to
> >>> wake_up() to match the wait_event().
> >>>
> >>> Signed-off-by: Haipeng YU <haipeng...@stericsson.com>
> >>> Signed-off-by: Linus Walleij <linus.wall...@linaro.org>
> >>> ---
> >>> drivers/usb/gadget/u_serial.c | 2 +-
> >>> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>>
> >>> diff --git a/drivers/usb/gadget/u_serial.c b/drivers/usb/gadget/u_serial.c
> >>> index f173952..2d074ba 100644
> >>> --- a/drivers/usb/gadget/u_serial.c
> >>> +++ b/drivers/usb/gadget/u_serial.c
> >>> @@ -887,7 +887,7 @@ static void gs_close(struct tty_struct *tty, struct
> >>> file *file)
> >>> pr_debug("gs_close: ttyGS%d (%p,%p) done!\n",
> >>> port->port_num, tty, file);
> >>>
> >>> - wake_up_interruptible(&port->port.close_wait);
> >>> + wake_up(&port->port.close_wait);
> >>> exit:
> >>> spin_unlock_irq(&port->port_lock);
> >>> }
> >>
> >> Ping on this, we're trying to figure out if we're doing the right
> >> thing here so help...
> >
> > Ping again. This is stopping our systems from shutting down
> > so would really appreciate some advice if this is the way
> > to go.
>
> Ping on this again, Felipe do you want us to repost?
>
> Soon one month in review...don't worry, they're all in my pending queue. Greg's pull request hasn't yet been merged upstream. One it is, you will start to receive my automated emails. -- balbi
signature.asc
Description: Digital signature
