Re: [PATCH 1/8] phy: tegra: xusb: t210: add XUSB device mode support

[Nagarjuna Kristam]

On 13-02-2019 12:34, Nagarjuna Kristam wrote:
>>>  EXPORT_SYMBOL_GPL(tegra_xusb_padctl_usb3_set_lfps_detect);
>>>  
>>> +int tegra_xusb_padctl_set_vbus_override(struct tegra_xusb_padctl *padctl)
>>> +{
>>> +   if (padctl->soc->ops->vbus_override)
>>> +           return padctl->soc->ops->vbus_override(padctl, true);
>>> +
>>> +   return -EINVAL;
>> It'd be best to stick to the -ENOSYS error code here.
>>
> will do
> 
Using ENOSYS is marked as checkpatch warning
        WARNING: ENOSYS means 'invalid syscall nr' and nothing else

I suggest to use ENOTSUP instead of EINVAL/ENOSYS.

-Nagarjuna
>>> +void tegra_phy_xusb_utmi_pad_power_on(struct phy *phy)
>>> +{
>>> +   struct tegra_xusb_lane *lane = phy_get_drvdata(phy);
>>> +   struct tegra_xusb_padctl *padctl = lane->pad->padctl;
>>> +
>>> +   if (padctl->soc->ops->utmi_pad_power_on)
>>> +           padctl->soc->ops->utmi_pad_power_on(phy);