On Thu, May 16, 2019 at 12:09:29PM +0530, Nagarjuna Kristam wrote: > Tegra210 has one XUSB device mode controller, which can be operated > HS and SS modes. Add DT support for XUSB device mode controller. > > Signed-off-by: Nagarjuna Kristam <[email protected]> > --- > arch/arm64/boot/dts/nvidia/tegra210.dtsi | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) > > diff --git a/arch/arm64/boot/dts/nvidia/tegra210.dtsi > b/arch/arm64/boot/dts/nvidia/tegra210.dtsi > index a550c0a..edef00b 100644 > --- a/arch/arm64/boot/dts/nvidia/tegra210.dtsi > +++ b/arch/arm64/boot/dts/nvidia/tegra210.dtsi > @@ -1184,6 +1184,25 @@ > status = "disabled"; > }; > > + xudc@700d0000 { > + compatible = "nvidia,tegra210-xudc"; > + reg = <0x0 0x700d0000 0x0 0x8000>, > + <0x0 0x700d8000 0x0 0x1000>, > + <0x0 0x700d9000 0x0 0x1000>;
Same comments regarding alignment as for the bindings patch.
> + interrupts = <GIC_SPI 44 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&tegra_car TEGRA210_CLK_XUSB_DEV>,
> + <&tegra_car TEGRA210_CLK_XUSB_SS>,
> + <&tegra_car TEGRA210_CLK_XUSB_SSP_SRC>,
> + <&tegra_car TEGRA210_CLK_XUSB_HS_SRC>,
> + <&tegra_car TEGRA210_CLK_XUSB_FS_SRC>;
Same here.
> + clock-names = "dev", "ss", "ss_src",
> + "hs_src", "fs_src";
No need to split this across multiple lines, it all fits within 72/80
characters.
Thierry
> + power-domains = <&pd_xusbdev>, <&pd_xusbss>;
> + power-domain-names = "dev", "ss";
> + nvidia,xusb-padctl = <&padctl>;
> + status = "disabled";
> + };
> +
> mipi: mipi@700e3000 {
> compatible = "nvidia,tegra210-mipi";
> reg = <0x0 0x700e3000 0x0 0x100>;
> --
> 2.7.4
>
signature.asc
Description: PGP signature
