Use usb_debug_root as root for our debugfs entry instead of creating our
own subdirectory under the debugfs root.

Reviewed-by: Guenter Roeck <li...@roeck-us.net>
Reviewed-by: Heikki Krogerus <heikki.kroge...@linux.intel.com>
Signed-off-by: Hans de Goede <hdego...@redhat.com>
---
Changes in v2:
- Prefix debugfs entry filename with "fusb302-"
---
 drivers/usb/typec/tcpm/fusb302.c | 13 +++++--------
 1 file changed, 5 insertions(+), 8 deletions(-)

diff --git a/drivers/usb/typec/tcpm/fusb302.c b/drivers/usb/typec/tcpm/fusb302.c
index 93244d6c4bff..603ab87b466e 100644
--- a/drivers/usb/typec/tcpm/fusb302.c
+++ b/drivers/usb/typec/tcpm/fusb302.c
@@ -26,6 +26,7 @@
 #include <linux/spinlock.h>
 #include <linux/string.h>
 #include <linux/types.h>
+#include <linux/usb.h>
 #include <linux/usb/typec.h>
 #include <linux/usb/tcpm.h>
 #include <linux/usb/pd.h>
@@ -206,23 +207,19 @@ static int fusb302_debug_show(struct seq_file *s, void *v)
 }
 DEFINE_SHOW_ATTRIBUTE(fusb302_debug);
 
-static struct dentry *rootdir;
-
 static void fusb302_debugfs_init(struct fusb302_chip *chip)
 {
-       mutex_init(&chip->logbuffer_lock);
-       if (!rootdir)
-               rootdir = debugfs_create_dir("fusb302", NULL);
+       char name[NAME_MAX];
 
-       chip->dentry = debugfs_create_file(dev_name(chip->dev),
-                                          S_IFREG | 0444, rootdir,
+       mutex_init(&chip->logbuffer_lock);
+       snprintf(name, NAME_MAX, "fusb302-%s", dev_name(chip->dev));
+       chip->dentry = debugfs_create_file(name, S_IFREG | 0444, usb_debug_root,
                                           chip, &fusb302_debug_fops);
 }
 
 static void fusb302_debugfs_exit(struct fusb302_chip *chip)
 {
        debugfs_remove(chip->dentry);
-       debugfs_remove(rootdir);
 }
 
 #else
-- 
2.23.0.rc2

Reply via email to