On Thu, Jan 31, 2013 at 11:08:54AM +0800, Peter Chen wrote: > On Wed, Jan 30, 2013 at 04:29:40PM +0100, Sascha Hauer wrote: > > From: Michael Grzeschik <[email protected]> > > > > +static void hw_phymode_configure(struct ci13xxx *ci) > > +{ > > + u32 portsc; > > + > > + /* > > + * The lpm version has the corresponding bits in the devlc register. > > + * Currently not implemented. > > + */ > > + if (ci->hw_bank.lpm) > > + return; > > + > > + switch (ci->platdata->phy_mode) { > > + case USBPHY_INTERFACE_MODE_UTMI: > > + portsc = PORTSC_PTS_PTW_UTMI; > > + break; > > + case USBPHY_INTERFACE_MODE_UTMIW: > > + portsc = PORTSC_PTS_PTW_UTMIW; > > + break; > > + case USBPHY_INTERFACE_MODE_ULPI: > > + portsc = PORTSC_PTS_PTW_ULPI; > > + break; > > + case USBPHY_INTERFACE_MODE_SERIAL: > > + portsc = PORTSC_PTS_PTW_SERIAL; > > + break; > > + case USBPHY_INTERFACE_MODE_HSIC: > > + portsc = PORTSC_PTS_PTW_HSIC; > > + break; > > + default: > > + return; > > + } > > + > > + hw_write(ci, OP_PORTSC, PORTSC_PTS_PTW, portsc); > > + > > + mdelay(10); > Please use usleep_range, can we recall which platform needs it? > As we as I know, there is no such delay at FSL internal release > code.
Then let's drop it. People will complain when they find the platform that needs it and then we can decide whether we add this unconditionally or do something better. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
