Hi, On Tue, Feb 19, 2013 at 06:50:08PM -0800, Paul Zimmerman wrote: > Add the DWC2 Kconfig and Makefile, and modify the USB Kconfig and > Makefile to include them > > Signed-off-by: Paul Zimmerman <[email protected]> > --- > drivers/usb/Kconfig | 2 ++ > drivers/usb/Makefile | 2 ++ > drivers/usb/dwc2/Kconfig | 27 +++++++++++++++++++++++++++ > drivers/usb/dwc2/Makefile | 15 +++++++++++++++ > 4 files changed, 46 insertions(+) > create mode 100644 drivers/usb/dwc2/Kconfig > create mode 100644 drivers/usb/dwc2/Makefile > > diff --git a/drivers/usb/Kconfig b/drivers/usb/Kconfig > index 4c90b51..4f1c6fe 100644 > --- a/drivers/usb/Kconfig > +++ b/drivers/usb/Kconfig > @@ -125,6 +125,8 @@ source "drivers/usb/core/Kconfig" > > source "drivers/usb/dwc3/Kconfig" > > +source "drivers/usb/dwc2/Kconfig" > + > source "drivers/usb/mon/Kconfig" > > source "drivers/usb/wusbcore/Kconfig" > diff --git a/drivers/usb/Makefile b/drivers/usb/Makefile > index f5ed3d7..efa98f7 100644 > --- a/drivers/usb/Makefile > +++ b/drivers/usb/Makefile > @@ -10,6 +10,8 @@ obj-$(CONFIG_USB_OTG_UTILS) += otg/ > > obj-$(CONFIG_USB_DWC3) += dwc3/ > > +obj-$(CONFIG_USB_DWC2) += dwc2/ > + > obj-$(CONFIG_USB_MON) += mon/ > > obj-$(CONFIG_PCI) += host/ > diff --git a/drivers/usb/dwc2/Kconfig b/drivers/usb/dwc2/Kconfig > new file mode 100644 > index 0000000..1051973 > --- /dev/null > +++ b/drivers/usb/dwc2/Kconfig > @@ -0,0 +1,27 @@ > +config USB_DWC2 > + tristate "DesignWare USB2 DRD Core Support" > + depends on USB > + select USB_OTG_UTILS > + help > + Say Y or M here if your system has a Dual Role HighSpeed > + USB controller based on the DesignWare HSOTG IP Core. > + > + If you choose to build this driver as dynamically linked > + modules, the core module will be called dwc2.ko, and the > + PCI bus interface module (if you have a PCI bus system) > + will be called dwc2_pci.ko. > + > +if USB_DWC2 > + > +config USB_DWC2_DEBUG > + bool "Enable Debugging Messages" > + help > + Say Y here to enable debugging messages in the DWC2 Driver. > + > +config USB_DWC2_VERBOSE > + bool "Enable Verbose Debugging Messages" > + depends on USB_DWC2_DEBUG > + help > + Say Y here to enable verbose debugging messages in the DWC2 Driver. > + > +endif > diff --git a/drivers/usb/dwc2/Makefile b/drivers/usb/dwc2/Makefile > new file mode 100644 > index 0000000..97f3027 > --- /dev/null > +++ b/drivers/usb/dwc2/Makefile > @@ -0,0 +1,14 @@ > +ccflags-$(CONFIG_USB_DWC2_DEBUG) += -DDEBUG > +ccflags-$(CONFIG_USB_DWC2_VERBOSE) += -DVERBOSE_DEBUG > + > +obj-$(CONFIG_USB_DWC2) += dwc2.o > + > +dwc2-y += core.o core_intr.o > +dwc2-y += hcd.o hcd_intr.o > +dwc2-y += hcd_queue.o hcd_ddma.o
look at how dwc3 handles build of host and peripheral roles, they're
both optional. I understand that this driver can only be built with host
role right now, but at least a comment here stating that once peripheral
role is added this should be fixed up would be great.
Here's dwc3's Makefile for reference:
ifneq ($(filter y,$(CONFIG_USB_DWC3_HOST) $(CONFIG_USB_DWC3_DUAL_ROLE)),)
dwc3-y += host.o
endif
ifneq ($(filter y,$(CONFIG_USB_DWC3_GADGET) $(CONFIG_USB_DWC3_DUAL_ROLE)),)
dwc3-y += gadget.o ep0.o
endif
other than that, patch looks good:
Acked-by: Felipe Balbi <[email protected]>
--
balbi
signature.asc
Description: Digital signature
