On Wed, 20 Feb 2013, Fabio Estevam wrote:

> From: Fabio Estevam <[email protected]>
> 
> Rather than reporting that the controller is about to be initialized, it is 
> more
> useful to indicate a succesful probe instead.
> 
> Signed-off-by: Fabio Estevam <[email protected]>
> ---
>  drivers/usb/host/ehci-mxc.c |    3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/usb/host/ehci-mxc.c b/drivers/usb/host/ehci-mxc.c
> index 18c30af..df2d0bf 100644
> --- a/drivers/usb/host/ehci-mxc.c
> +++ b/drivers/usb/host/ehci-mxc.c
> @@ -57,8 +57,6 @@ static int ehci_mxc_drv_probe(struct platform_device *pdev)
>       struct device *dev = &pdev->dev;
>       struct ehci_hcd *ehci;
>  
> -     dev_info(&pdev->dev, "initializing i.MX USB Controller\n");
> -
>       if (!pdata) {
>               dev_err(dev, "No platform data given, bailing out.\n");
>               return -EINVAL;
> @@ -157,6 +155,7 @@ static int ehci_mxc_drv_probe(struct platform_device 
> *pdev)
>       if (ret)
>               goto err_add;
>  
> +     dev_info(&pdev->dev, "initialized succesfully\n");
>       return 0;

Plenty of drivers don't include any message like this at all.  You 
might as well get rid of it entirely.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to