Hi Dmitry, Thanks for catching this. I've applied it to my for-usb-linus-queue, and I'll be sending it to Greg as a bug fix after 3.9-rc1 is out.
Sarah Sharp On Mon, Feb 25, 2013 at 10:56:01AM -0800, Dmitry Torokhov wrote: > According to XHCI specification (5.5.2.1) the IP is bit 0 and IE is bit 1 > of IMAN register. Previously their definitions were reversed. > > Even though there are no ill effects being observed from the swapped > definitions (because IMAN_IP is RW1C and in legacy PCI case we come in > with it already set to 1 so it was clearing itself even though we were > setting IMAN_IE instead of IMAN_IP), we should still correct the values. > > Signed-off-by: Dmitry Torokhov <[email protected]> > --- > > drivers/usb/host/xhci.h | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/usb/host/xhci.h b/drivers/usb/host/xhci.h > index f791bd0..2c510e4 100644 > --- a/drivers/usb/host/xhci.h > +++ b/drivers/usb/host/xhci.h > @@ -206,8 +206,8 @@ struct xhci_op_regs { > /* bits 12:31 are reserved (and should be preserved on writes). */ > > /* IMAN - Interrupt Management Register */ > -#define IMAN_IP (1 << 1) > -#define IMAN_IE (1 << 0) > +#define IMAN_IE (1 << 1) > +#define IMAN_IP (1 << 0) > > /* USBSTS - USB status - status bitmasks */ > /* HC not running - set to 1 when run/stop bit is cleared. */ -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
