Make sure to wake up any process sleeping on the modem-status-change queue at port remove.
Currently a process waiting on modem status changes will not be woken on device disconnect. Note that we need to use the disconnected flag to detect disconnect as the port private data may have been freed when woken up. Cc: stable <[email protected]> Signed-off-by: Johan Hovold <[email protected]> --- drivers/usb/serial/spcp8x5.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/usb/serial/spcp8x5.c b/drivers/usb/serial/spcp8x5.c index 91ff8e3..3245bfa 100644 --- a/drivers/usb/serial/spcp8x5.c +++ b/drivers/usb/serial/spcp8x5.c @@ -192,6 +192,7 @@ static int spcp8x5_port_remove(struct usb_serial_port *port) struct spcp8x5_private *priv; priv = usb_get_serial_port_data(port); + wake_up_interruptible(&priv->delta_msr_wait); kfree(priv); return 0; @@ -532,6 +533,9 @@ static int spcp8x5_wait_modem_info(struct usb_serial_port *port, if (signal_pending(current)) return -ERESTARTSYS; + if (port->serial->disconnected) + return -EIO; + spin_lock_irqsave(&priv->lock, flags); status = priv->line_status; spin_unlock_irqrestore(&priv->lock, flags); -- 1.8.1.1 -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
