On Tue, Mar 12, 2013 at 11:46:49AM +0200, Felipe Balbi wrote: > On Tue, Mar 12, 2013 at 05:03:18PM +0800, Peter Chen wrote: > > Let the common struct usb_gadget own it. > > > > CC: Alexander Shishkin <[email protected]> > > CC: Jean-Christophe PLAGNIOL-VILLARD <[email protected]> > > CC: Li Yang <[email protected]> > > CC: Roland Stigge <[email protected]> > > CC: Yu Xu <[email protected]> > > CC: Chao Xie <[email protected]> > > CC: Eric Miao <[email protected]> > > CC: Ben Dooks <[email protected]> > > Signed-off-by: Peter Chen <[email protected]> > > you need to split this patch, should be something like below: > > for_each_driver() { > initialize gadget->vbus_active (don't remove private method) > } > > add vbus_active support to udc-core > > for_each_driver() { > remove driver's private vbus_active method > } > > you need one patch per driver so it's easy to review and ack.
Eg, If I changed 10 udc drivers, I need 1(add vbus_active to struct usb_gadget) + 10 + 1 + 10 = 22 patches? > > -- > balbi -- Best Regards, Peter Chen -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
