On Wednesday 13 March 2013 22:42:37 Ming Lei wrote:
> On Wed, Mar 13, 2013 at 10:36 PM, Oliver Neukum <[email protected]> wrote:
> > On Wednesday 13 March 2013 22:22:53 Du Xing wrote:
> >> From: Du Xing [email protected]
> >>
> >> In skel_read,the reader blocked in wait_for_completion before submit bulk
> >> in urb.
> >> Using processed_urb is totally unnecessary, remove it can fix the bug.
> >
> > The processed_urb is intended for the case that the interruptible wait in
> > skel_read was interrupted. So the diagnosis is good, but the fix is dubious.
>
> If skel_read is interrupted, the function will exit, so this code won't be run
> under the situation.
But it will be run when the next read() call is made. The question is what
happens
to the counter in the struct completion.
Regards
Oliver
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
