Alexander, On Wed, Mar 13, 2013 at 4:59 PM, Alexander Graf <[email protected]> wrote: > On my Exynos 5 based Arndale system, I need to pull the reset line down > and then let it go up again to actually perform a reset. Without that > reset, I can't find any USB hubs on my bus, rendering the USB controller > useless. > > We also only need to reset the line after the phy node has been found. > This way we don't accidently reserve the vbus GPIO pin, but later on > defer the creation of our controller, because the phy device tree node > hasn't been probed yet. > > This patch implements the above logic, making EHCI and OHCI work on > Arndale systems for me. > > Signed-off-by: Alexander Graf <[email protected]> > CC: Vivek Gautam <[email protected]> > CC: Jingoo Han <[email protected]> > CC: Alan Stern <[email protected]> > CC: Kukjin Kim <[email protected]> > CC: Felipe Balbi <[email protected]> > CC: Greg Kroah-Hartman <[email protected]> > CC: Doug Anderson <[email protected]> > > --- > > v1 -> v2: > > - remove gpio_free call > - move reset logic after phy node search
Seems fine to me. I guess the earlier problem you wrote about was the probe failure, then? I think that the reason I don't tend to get the probe failure is that I've got my device tree ordered differently so that the phy gets initted in a different order. I'll send up the devm_ patch atop this. Reviewed-by: Doug Anderson <[email protected]> Thanks! :) -Doug -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
