On Sat, Mar 23, 2013 at 08:35:40PM +0200, Felipe Balbi wrote: > On Fri, Mar 22, 2013 at 05:47:53PM -0700, Paul Zimmerman wrote: > > Previously, when an active urb was dequeued, its host channel would > > not always be released. There is some special handling for this in > > dwc2_hc_chhltd_intr_dma, but when it was the last urb/qtd in its qh, a > > safeguard in dwc2_hc_n_intr would short-circuit and prevent the regular > > interrupt handlers from running, without releasing the channel. > > > > This is easily triggered when using a 3G modem using the option driver. > > Opening and closing any ttyUSBx device will eat up a host channel that > > is forever unusable from that point on. > > > > Signed-off-by: Matthijs Kooijman <[email protected]> > > Signed-off-by: Paul Zimmerman <[email protected]> > > since this is basically Matthijs' patch with a few extra details from > you, it should still be marked as authored by Matthijs. All you did was > add a few extra checks for qtd being valid and fixed comment styles. > > What you can (should?) do is add a note on commit log specifying what > you have changed, something like below:
<snip> I agree, Paul, please redo these two patches and resend them, with the correct authorship information intact. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
