Hi, On Thu, Apr 11, 2013 at 09:15:28PM +0200, Matthijs Kooijman wrote: > Hi Felipe, > > thanks for your comments. > > On Thu, Apr 11, 2013 at 09:36:23PM +0300, Felipe Balbi wrote: > > On Thu, Apr 11, 2013 at 06:43:48PM +0200, Matthijs Kooijman wrote: > > > This adds a dwc_platform.ko module that can be loaded by using > > > compatible = "snps,dwc2" in a device tree. > > > > > > Signed-off-by: Matthijs Kooijman <matth...@stdin.nl> > [] > > > +Required properties: > > > +- compatible : "snps,dwc2" > > > > please use the company's full name -> synopsys. > > I've done as documented: > > $ cat Documentation/devicetree/bindings/vendor-prefixes.txt | grep Synopsys > snps Synopsys, Inc. > > Further grepping shows that only dwc3 uses synopsys, all others use > snps.
fair enough, in that case I'll fix dwc3 for v3.10. A bit odd not to use
the full name, though, but meh..
> > > +static int dwc2_driver_remove(struct platform_device *dev)
> > > +{
> > > + struct dwc2_hsotg *hsotg = platform_get_drvdata(dev);
> > > +
> > > + dev_dbg(&dev->dev, "%s(%p)\n", __func__, dev);
> >
> > I don't think you need this dev_dbg() line.
> []
> > > + dev_dbg(&dev->dev, "%s(%p)\n", __func__, dev);
> >
> > neither this one.
> >
> []
> > > + dev_dbg(&dev->dev, "hsotg=%p\n", hsotg);
> >
> > or this.
>
> These are just copied from pci.c, to make these as similar as possible.
> I can drop them and send a patch to drop them from pci.c as well, since
> I agree they're rather pointless.
right, makes sense to me.
--
balbi
signature.asc
Description: Digital signature
