On Tue, Jun 11, 2013 at 12:43:25PM +0200, Johan Hovold wrote:
> On Mon, Jun 10, 2013 at 02:39:06PM -0700, Greg KH wrote:
> > On Thu, Jun 06, 2013 at 11:21:54AM -0700, Greg KH wrote:
> > > On Thu, Jun 06, 2013 at 11:58:56AM +0200, Johan Hovold wrote:
> 
> > > > Greg, perhaps we should consider backporting the wait-until-sent
> > > > patches (i.e. 0693196fe..4746b6c6e)?
> > > 
> > > Yes, that's a good idea, I'll do that for the next round of stable
> > > updates, after this next release tomorrow.
> > 
> > I applied these, plus a few others in order to get them all to apply and
> > build properly.
> > 
> > But the last patch, 4746b6c6e, didn't apply, and I don't think we really
> > need it for the 3.9 kernel, do we?
> 
> No, you're right. It's merely a clean up and slight optimisation as no
> chars_in_buffer needs the disconnect mutex after the other changes. Not
> sure why it wouldn't apply, though.
> 
> I was a bit sloppy when I gave the commit refs above -- it should have
> been
> 
>       0693196^..b16634a
> 
> More specifically:
> 
> 4746b6c USB: serial: clean up chars_in_buffer
> 
>       This one is not strictly necessary, but should apply to v3.9.

It doesn't apply to 3.9 at all, so it being not really necessary, I'll
not include it :)

> ff93b19 USB: ti_usb_3410_5052: fix chars_in_buffer overhead
> 
>       This should not be applied to v3.9 as the problem it fixes
>       wasn't introduced until v3.10-rc1.
> 
>       It seems you had to add two other patches to get this one to
>       apply. They should be dropped as well.

Ok, I've dropped all 3 of these now.

> b16634a USB: io_ti: fix chars_in_buffer overhead
> 
>       Needed in 3.9.

Good, I have that one.

> a37025b USB: ftdi_sio: fix chars_in_buffer overhead
> c413364 USB: ftdi_sio: clean up get_modem_status
> dcf0105 USB: serial: add generic wait_until_sent implementation
> 
>       These three are also needed in 3.9 (and also 3.8).

I have these three. 3.8-stable is dead as far as I'm concerned, so I
can't do anything about it :)

> 0693196 USB: serial: add wait_until_sent operation
> 
>       Needed in 3.9 (and 3.8). (You noticed my refspec did not include
>       it and added it.)

Yes, other things were breaking without it.

> Sorry about the confusion.

No worries, I've dropped the three patches listed above, so we should be
all good to go.  I'll do a 3.9.6-rc1 release today to get these all out
to people to test.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to