On Mon, 2013-08-05 at 16:47 +0800, Ming Lei wrote:

> @@ -1268,10 +1298,14 @@ netdev_tx_t usbnet_start_xmit (struct sk_buff *skb,
>       entry = (struct skb_data *) skb->cb;
>       entry->urb = urb;
>       entry->dev = dev;
> -     entry->length = length;
>  
>       usb_fill_bulk_urb (urb, dev->udev, dev->out,
>                       skb->data, skb->len, tx_complete, skb);
> +     if (dev->can_dma_sg) {
> +             if (build_dma_sg(skb, urb) < 0)
> +                     goto drop;

This is still missing a kfree() for urb->sg in the error case
of usbnet_start_xmit().

        Regards
                Oliver


--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to