On Tue, 6 Aug 2013, Peter Chen wrote: > In order to increase test coverage, we can change the interval between > two remote wakeups every time, and the interval can be any user defined > value. This change will no affect current behavior if the user does not > use two introduced module paramters. > > Signed-off-by: Peter Chen <[email protected]> > --- > drivers/usb/gadget/zero.c | 26 +++++++++++++++++++++++--- > 1 files changed, 23 insertions(+), 3 deletions(-) > > diff --git a/drivers/usb/gadget/zero.c b/drivers/usb/gadget/zero.c > index 0deb9d6..076f2be 100644 > --- a/drivers/usb/gadget/zero.c > +++ b/drivers/usb/gadget/zero.c > @@ -38,7 +38,6 @@ > */ > > /* #define VERBOSE_DEBUG */ > - > #include <linux/kernel.h> > #include <linux/slab.h> > #include <linux/device.h>
This hunk doesn't belong in the patch. > @@ -95,6 +94,18 @@ unsigned autoresume = DEFAULT_AUTORESUME; > module_param(autoresume, uint, S_IRUGO); > MODULE_PARM_DESC(autoresume, "zero, or seconds before remote wakeup"); > > +/* Maximum Autoresume time */ > +unsigned max_autoresume; > +module_param(max_autoresume, uint, S_IRUGO); > +MODULE_PARM_DESC(max_autoresume, "maximum seconds before remote wakeup"); > + > +/* Internal between two remote wakeups */ s/Internal/Interval/ > +unsigned autoresume_interal_ms; s/interal/interval/ > +module_param(autoresume_interal_ms, uint, S_IRUGO); s/interal/interval/ > +MODULE_PARM_DESC(autoresume_interal_ms, s/interal/interval/ > + "milliseconds internal between sending two wakeups"); This description is not accurate. It should be more like "Milliseconds to increase successive wakeup delays", or "Milliseconds to add to the wakeup delay after each new wakeup". Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
