On Tue, Aug 13, 2013 at 10:03:01PM +0200, Frank Schäfer wrote: > The chip type distinction is getting more and more relevant and > complicating, so always print the chip type. > Printing a name string is also much better than just printing an > internal index number. > > Signed-off-by: Frank Schäfer <[email protected]> > --- > drivers/usb/serial/pl2303.c | 15 ++++++++++----- > 1 Datei geändert, 10 Zeilen hinzugefügt(+), 5 Zeilen entfernt(-) > > diff --git a/drivers/usb/serial/pl2303.c b/drivers/usb/serial/pl2303.c > index 7efb39c..5ca1443 100644 > --- a/drivers/usb/serial/pl2303.c > +++ b/drivers/usb/serial/pl2303.c > @@ -177,6 +177,7 @@ static int pl2303_startup(struct usb_serial *serial) > { > struct pl2303_serial_private *spriv; > enum pl2303_type type = type_0; > + char *type_str = "unknown (treating as type_0)"; > unsigned char *buf; > > spriv = kzalloc(sizeof(*spriv), GFP_KERNEL); > @@ -189,14 +190,18 @@ static int pl2303_startup(struct usb_serial *serial) > return -ENOMEM; > } > > - if (serial->dev->descriptor.bDeviceClass == 0x02) > + if (serial->dev->descriptor.bDeviceClass == 0x02) { > type = type_0; > - else if (serial->dev->descriptor.bMaxPacketSize0 == 0x40) > + type_str = "type_0"; > + } else if (serial->dev->descriptor.bMaxPacketSize0 == 0x40) { > type = HX; > - else if (serial->dev->descriptor.bDeviceClass == 0x00 > - || serial->dev->descriptor.bDeviceClass == 0xFF) > + type_str = "X/HX"; > + } else if (serial->dev->descriptor.bDeviceClass == 0x00 > + || serial->dev->descriptor.bDeviceClass == 0xFF) { > type = type_1; > - dev_dbg(&serial->interface->dev, "device type: %d\n", type); > + type_str = "type_1"; > + } > + dev_info(&serial->interface->dev, "device type: %s\n", type_str);
No, that's just noise in the system, no one really cares about this. Leave it as dev_dbg() please. The string is nice to have though. Can you resend this? thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
