Hello Lee Jones,
This is a semi-automatic email about new static checker warnings.
The patch 2968da0b2c72: "usb: musb: ux500: attempt to find channels
by name before using pdata" from May 15, 2013, leads to the following
Smatch complaint:
drivers/usb/musb/ux500_dma.c:335 ux500_dma_controller_start()
error: we previously assumed 'data' could be null (see line 313)
drivers/usb/musb/ux500_dma.c
312 channel_array = controller->rx_channel;
313 param_array = data ? data->dma_rx_param_array : NULL;
^^^^
Old check.
314 chan_names = (char **)iep_chan_names;
315
316 for (dir = 0; dir < 2; dir++) {
317 for (ch_num = 0;
318 ch_num < UX500_MUSB_DMA_NUM_RX_TX_CHANNELS;
319 ch_num++) {
320 ux500_channel = &channel_array[ch_num];
321 ux500_channel->controller = controller;
322 ux500_channel->ch_num = ch_num;
323 ux500_channel->is_tx = is_tx;
324
325 dma_channel = &(ux500_channel->channel);
326 dma_channel->private_data = ux500_channel;
327 dma_channel->status = MUSB_DMA_STATUS_FREE;
328 dma_channel->max_len = SZ_16M;
329
330 ux500_channel->dma_chan =
331 dma_request_slave_channel(dev,
chan_names[ch_num]);
332
333 if (!ux500_channel->dma_chan)
334 ux500_channel->dma_chan =
335 dma_request_channel(mask,
336
data->dma_filter,
^^^^^^^^^^^^^^^^
This is not actually new, it just got shifted around a bit. But you
touched it last. :P
337
param_array[ch_num]);
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
