On Thu, 26 Sep 2013, Bjorn Helgaas wrote: > On Thu, Sep 26, 2013 at 10:45 AM, Greg Kroah-Hartman > <[email protected]> wrote: > > On Fri, Sep 13, 2013 at 01:57:42PM -0600, Bjorn Helgaas wrote: > >> usb_bus_list_lock is used by usbfs, but that's in the same module as > >> hcd.c, so there's no need to export it. Update the comment to show > >> that it protects the set of root hubs as well as the list of buses. > > > > usbmon also uses this, so this patch breaks the build: > > > > ERROR: "usb_bus_list_lock" [drivers/usb/mon/usbmon.ko] undefined! > > Oops, sorry, I should have noticed that, sorry.
Me too. :-( I guess the comment in the definition needs to be changed. It should say that usb_bus_list_lock is exported for usbmon, not usbfs. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
