On Tue, Oct 22, 2013 at 05:06:35PM +0800, kbuild test robot wrote:
> tree:   git://gitorious.org/x0148406-public/linux-kernel am43x-next
> head:   0f0018fe622301c41bc9a332cbc75f716ca296db
> commit: 36ed03f7796a6695ee1b6c4893ef022328a50e70 [2892/6980] usb: gadget: 
> zero: Add flexible auto remote wakeup test method
> reproduce: make C=1 CF=-D__CHECK_ENDIAN__
> 
> 
> sparse warnings: (new ones prefixed by >>)
> 
>    drivers/usb/gadget/zero.c:94:10: sparse: symbol 'autoresume' was not 
> declared. Should it be static?
> >> drivers/usb/gadget/zero.c:99:10: sparse: symbol 'max_autoresume' was not 
> >> declared. Should it be static?
> >> drivers/usb/gadget/zero.c:104:10: sparse: symbol 'autoresume_interval_ms' 
> >> was not declared. Should it be static?
>    drivers/usb/gadget/zero.c:156:9: sparse: advancing past deep designator
> 
> Please consider folding the attached diff :-)
> 
> ---
> 0-DAY kernel build testing backend              Open Source Technology Center
> http://lists.01.org/mailman/listinfo/kbuild                 Intel Corporation

> From: Fengguang Wu <[email protected]>
> Subject: [PATCH x0148406] usb: gadget: zero: max_autoresume can be static
> TO: Peter Chen <[email protected]>
> CC: Felipe Balbi <[email protected]>
> CC: [email protected] 
> CC: [email protected] 
> 
> CC: Peter Chen <[email protected]>
> CC: Felipe Balbi <[email protected]>
> Signed-off-by: Fengguang Wu <[email protected]>
> ---
>  zero.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/usb/gadget/zero.c b/drivers/usb/gadget/zero.c
> index 0dd07ae..4b1189a 100644
> --- a/drivers/usb/gadget/zero.c
> +++ b/drivers/usb/gadget/zero.c
> @@ -96,12 +96,12 @@ module_param(autoresume, uint, S_IRUGO);
>  MODULE_PARM_DESC(autoresume, "zero, or seconds before remote wakeup");
>  
>  /* Maximum Autoresume time */
> -unsigned max_autoresume;
> +static unsigned max_autoresume;
>  module_param(max_autoresume, uint, S_IRUGO);
>  MODULE_PARM_DESC(max_autoresume, "maximum seconds before remote wakeup");
>  
>  /* Interval between two remote wakeups */
> -unsigned autoresume_interval_ms;
> +static unsigned autoresume_interval_ms;
>  module_param(autoresume_interval_ms, uint, S_IRUGO);
>  MODULE_PARM_DESC(autoresume_interval_ms,
>               "milliseconds to increase successive wakeup delays");

Thanks, maybe you can change all three module parameters as static.

-- 

Best Regards,
Peter Chen

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to