On Wed, Nov 13, 2013 at 10:25:01PM +0100, Oliver Neukum wrote:
> On Thu, 2013-11-14 at 05:31 +0900, Greg KH wrote:
> > On Wed, Nov 13, 2013 at 06:13:06PM +0100, [email protected] wrote:
> > > From: Oliver Neukum <[email protected]>
> > > 
> > > To allow a full switch to dynamic debugging make the
> > > debug parameter conditional on defined(DEBUF) || defined(DYNAMIC_DEBUG)
> > > 
> > > Signed-off-by: Oliver Neukum <[email protected]>
> > > ---
> > >  drivers/usb/host/uhci-hcd.c | 44 
> > > +++++++++++++++++++++++---------------------
> > >  1 file changed, 23 insertions(+), 21 deletions(-)
> > > 
> > > diff --git a/drivers/usb/host/uhci-hcd.c b/drivers/usb/host/uhci-hcd.c
> > > index 4a86b63..c53058d 100644
> > > --- a/drivers/usb/host/uhci-hcd.c
> > > +++ b/drivers/usb/host/uhci-hcd.c
> > > @@ -69,19 +69,14 @@ MODULE_PARM_DESC(ignore_oc, "ignore hardware 
> > > overcurrent indications");
> > >   *            show all queues in /sys/kernel/debug/uhci/[pci_addr]
> > >   * debug = 3, show all TDs in URBs when dumping
> > >   */
> > > -#ifdef DEBUG
> > > -#define DEBUG_CONFIGURED 1
> > > +#if defined(DEBUG) || defined(DYNAMIC_DEBUG)
> > 
> > My goal would be to see DEBUG go away entirely, so why not just remove
> > it here as well and only depend on DYNAMIC_DEBUG?
> 
> Well, shouldn't that wait for the change of the Makefile?

We have to remove it from the drivers first, before we can remove it
from the Makefile :)

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to