Hi Felipe, > Hi, > > On Tue, Nov 26, 2013 at 10:33:44AM -0600, Felipe Balbi wrote: > > this header uses spinlocks and errno values, so > > we must include <linux/spinlock.h> and <linux/errno.h> > > to avoid build errors. > > > > Signed-off-by: Felipe Balbi <[email protected]> > > Anton, I had to rework your patch series quite a bit in order to make
Thank you. > it > acceptable. It seems unlikely that you compile-tested your series, > considering we would very clearly see build errors after moving the > header around. > > Your driver depends (or depended?) too much on indirect header > inclusions. Currently only Freescale OTG Transceiver Driver uses OTG FSM. After applying patches it was compiled without errors. > Make sure to build test each and every patch in your series next time, Usually I do. > or they won't make it to mainline. Thanks -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
