From: Alan Stern <st...@rowland.harvard.edu>
Evidently some wacky USB-ATA bridges don't recognize the SYNCHRONIZE
CACHE command, as shown in this email thread:
http://marc.info/?t=138978356200002&r=1&w=2
The fact that we can't tell them to drain their caches shouldn't
prevent the system from going into suspend. Therefore sd_sync_cache()
shouldn't return an error if the device replies with an Invalid
Command ASC.
Signed-off-by: Alan Stern <st...@rowland.harvard.edu>
Reported-by: Sven Neumann <s.neum...@raumfeld.com>
Tested-by: Daniel Mack <zon...@gmail.com>
CC: Oliver Neukum <oli...@neukum.org>
CC: <sta...@vger.kernel.org>
---
Hi,
this patch has been around for awhile, but hasn't gained much
attraction, and hasn't been merged anywhere yet. Which is sad,
as it fixes a bug on real hardware when going to suspend :)
Could anyone from the SCSI people have a quick look maybe?
Thanks,
Daniel
drivers/scsi/sd.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c
index 470954a..36d1a23 100644
--- a/drivers/scsi/sd.c
+++ b/drivers/scsi/sd.c
@@ -1463,8 +1463,8 @@ static int sd_sync_cache(struct scsi_disk *sdkp)
sd_print_sense_hdr(sdkp, &sshdr);
/* we need to evaluate the error return */
if (scsi_sense_valid(&sshdr) &&
- /* 0x3a is medium not present */
- sshdr.asc == 0x3a)
+ (sshdr.asc == 0x3a || /* medium not present */
+ sshdr.asc == 0x20)) /* invalid command */
/* this is no error here */
return 0;
--
1.8.5.3
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
