Sergei Shtylyov <[email protected]> writes:
> Hello.
>
> On 06/09/2014 11:52 PM, Robert Jarzmik wrote:
>> regs = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>> + udc->regs = devm_request_and_ioremap(&pdev->dev, regs);
>
> Isn't this function deprecated in favor of devm_ioremap_resource()?
I don't know. It's not marked as deprecated. Could you give me a pointer ?
>
>> if (!regs)
>
> s/regs/udc->regs/.
Good catch.
>> if (retval != 0) {
>> dev_err(udc->dev, "%s: can't get irq %i, err %d\n",
>> driver_name, udc->irq, retval);
>> - goto err_irq;
>> + goto err;
>
> Why not just *return*?
Sure, simpler would be a return :)
>
>> }
>>
>> retval = usb_add_gadget_udc(&pdev->dev, &udc->gadget);
>> if (retval)
>> - goto err_add_udc;
>> + goto err;
>
> Likewise.
Ditto.
Thanks for the review.
Cheers.
--
Robert
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
