On 07/25/2014 11:01 PM, Hans de Goede wrote:
> xhci_queue_new_dequeue_state is the only caller of queue_set_tr_deq
> and queue_set_tr_deq checks for SET_DEQ_PENDING, where as
> xhci_queue_new_dequeue_state sets it which is inconsistent.
> 
> Simply fold the 2 into one is a nice cleanup and fixes the inconsistency.
> 
> Signed-off-by: Hans de Goede <[email protected]>
> ---
>  drivers/usb/host/xhci-ring.c | 83 
> +++++++++++++++++---------------------------
>  1 file changed, 32 insertions(+), 51 deletions(-)
> 

Nice, looks very good as well, cleans up the code quite a lot.
Again, haven't applied as waiting for the rebased version, but I got nothing to 
add.

Thanks
-Mathias

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to