Hello.

On 8/16/2014 2:44 PM, Jaša Bartelj wrote:

Mainly whitespace changes and some bracing style clean-ups.

Signed-off-by: Jaša Bartelj <[email protected]>
---
  drivers/usb/serial/ftdi_sio.c     | 20 +++++++++++---------
  drivers/usb/serial/ftdi_sio_ids.h |  4 ++--
  2 files changed, 13 insertions(+), 11 deletions(-)

diff --git a/drivers/usb/serial/ftdi_sio.c b/drivers/usb/serial/ftdi_sio.c
index 19cf267..620845b 100644
--- a/drivers/usb/serial/ftdi_sio.c
+++ b/drivers/usb/serial/ftdi_sio.c
[...]
@@ -1450,8 +1452,7 @@ check_and_exit:
             (old_priv.custom_divisor != priv->custom_divisor))) {
                change_speed(tty, port);
                mutex_unlock(&priv->cfg_lock);
-       }
-       else
+       } else
                mutex_unlock(&priv->cfg_lock);

Actually, if one arm of the *if* statement has {}, the kernel style dictates that all the other arms should have {} too. High time to fix it.

[...]
@@ -1507,15 +1508,15 @@ static void ftdi_determine_type(struct usb_serial_port 
*port)

                /* Determine interface code. */
                inter = serial->interface->altsetting->desc.bInterfaceNumber;
-               if (inter == 0) {
+               if (inter == 0)
                        priv->interface = INTERFACE_A;
-               } else  if (inter == 1) {
+               else  if (inter == 1)
                        priv->interface = INTERFACE_B;
-               } else  if (inter == 2) {
+               else  if (inter == 2)
                        priv->interface = INTERFACE_C;
-               } else  if (inter == 3) {
+               else  if (inter == 3)
                        priv->interface = INTERFACE_D;
-               }
+

   The above is asking to be a *switch* statement...

[...]

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to